Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add FORCE_QT_API environment variable #194

Merged
merged 2 commits into from
Jul 23, 2019
Merged

PR: Add FORCE_QT_API environment variable #194

merged 2 commits into from
Jul 23, 2019

Conversation

JasonGilholme
Copy link
Contributor

@JasonGilholme JasonGilholme commented Jul 5, 2019

In response to this thread:

#192

-J


Fixes #192.

@JasonGilholme
Copy link
Contributor Author

It looks like the python 2.7 tests fail due to an update to shiboken2 as PySide has been bumped from 5.12.3 -> 5.13 on June 27.

Previous run on master: https://circleci.com/gh/spyder-ide/qtpy/686
Latest run of master: https://circleci.com/gh/spyder-ide/qtpy/692

Release history of Shiboken2: https://pypi.org/project/shiboken2/#history

You'll need to address these changes at some point as anyone trying to use Qtpy on that version will experience an error when using the Qt3DAnimation module.

@goanpeca goanpeca self-assigned this Jul 5, 2019
@goanpeca goanpeca added this to the v2.0 milestone Jul 5, 2019
@goanpeca
Copy link
Member

goanpeca commented Jul 5, 2019

Thanks for working on this @JasonGilholme.

I will open a new issues to track the problem -> see #195

@JasonGilholme
Copy link
Contributor Author

JasonGilholme commented Jul 5, 2019 via email

@goanpeca
Copy link
Member

goanpeca commented Jul 5, 2019

Has there ever been any discussion regarding joining efforts with the Qt.py
project?

Yes, they were but I guess the author of Qt.Py had different goals in mind and decided to create a new project with an unfortunate (similar) name.

@JasonGilholme
Copy link
Contributor Author

Has there ever been any discussion regarding joining efforts with the Qt.py
project?

Yes, they were but I guess the author of Qt.Py had different goals in mind and decided to create a new project with an unfortunate (similar) name.

Interesting, from your point of view, do you see a major difference in the goals of the two projects?

Don't get me started on the names. It's bad enough having 2 libs let alone having basically the same names.

@goanpeca
Copy link
Member

goanpeca commented Jul 5, 2019

Interesting, from your point of view, do you see a major difference in the goals of the two projects?

To be honest I do not know what qt.py does since we do not use it. I think the author wanted to have a shim in a single file instead of the way we chose to do it with separate files etc...

Regarding the name, well it is really not our fault since this project was created first.

@JasonGilholme
Copy link
Contributor Author

JasonGilholme commented Jul 5, 2019 via email

qtpy/__init__.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 modified the milestones: v2.0, v1.9.0 Jul 6, 2019
@ccordoba12 ccordoba12 changed the title Add FORCE_QT_API environment variable PR: Add FORCE_QT_API environment variable Jul 8, 2019
@ccordoba12
Copy link
Member

@JasonGilholme, please rebase in top of master to get the fix to our failing tests.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready because the failure is unrelated to @JasonGilholme changes (as noted above).

@ccordoba12 ccordoba12 merged commit 167c36a into spyder-ide:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding Selection Logic
3 participants